Missing an expected key: 'NSPrivacyCollectedDataTypes'

OguzYuuksel commented 5 months ago

Description

Missing an expected key: 'NSPrivacyCollectedDataTypes' xxx.app/swift-composable-architecture_ComposableArchitecture.bundle/PrivacyInfo.xcprivacy

Checklist

[ ] I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
[ ] If possible, I've reproduced the issue using the main branch of this package.
[X] This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior

No response

Actual behavior

Error

Steps to reproduce

Open your project in Xcode.
Choose Product > Archive. Xcode creates the archive and reveals it in the organizer.
Control-click the archive in the organizer and choose Generate Privacy Report.
Choose a location to save the privacy report.
Switch to Finder.
Navigate to the location where you saved the privacy report, and double-click to open the report in Preview.

The Composable Architecture version information

1.10.0

Destination operating system

No response

Xcode version information

15.3.0

Swift Compiler version information

swift-driver version: 1.90.11.1 Apple Swift version 5.10 (swiftlang-5.10.0.13 clang-1500.3.9.4)
Target: arm64-apple-macosx14.0

mbrandonw commented 5 months ago

Hi @OguzYuuksel, thanks for the report. Can you clarify whether or not this is preventing you from submitting your app to the App Store? Or is it just a warning?

@DandyLyons You added this file in #2930. Is there something missing from the plist that we need to add?

If we can't get this sorted in the next day or so we will have to remove the privacy file so that it does not cause issues for others.

jshier commented 5 months ago

Apple's latest update on the manifests seems to have removed the May 1st deadline, which hasn't passed yet. I'm not sure whether the lack of this key would be a blocking issue or whether it's just part of the PDF generation, but you can fix it by adding the proper empty root key.

<key>NSPrivacyCollectedDataTypes</key>
<array/>

mbrandonw commented 5 months ago

Hi @jshier, thanks for the info! If you are @DandyLyons want to PR it we'll definitely merge it, or I can take care of it later today.

DandyLyons commented 5 months ago

Thanks. I'll work on it now.

OguzYuuksel commented 5 months ago

Hello, I was aiming to ensure compliance with Apple's updated privacy requirements for our app. Upon inspection, I noticed the reported issue. However, it seems that Apple has removed the May 1st deadline, so this issue is not currently blocker.

@DandyLyons thank you for taking care of it.

stephencelis commented 5 months ago

@DandyLyons Don't want to step on your toes if you're in the middle of it, but if you can't get to the PR right now we can take care of it. We're about to merge a few other fixes and cut a patch release, so it'd be nice to get this into the fold :smile:

DandyLyons commented 5 months ago

Just posted it.

pointfreeco / swift-composable-architecture