search

pointfreeco / swift-composable-architecture

A library for building applications in a consistent and understandable way, with composition, testing, and ergonomics in mind.
https://www.pointfree.co/collections/composable-architecture
MIT License
12.5k stars 1.46k forks source link

Improve store scoping in benchmark #3233

Closed woxtu closed 3 months ago

woxtu commented 3 months ago

This PR resolves the following warning message:

'scope(state:action:)' is deprecated: Pass 'state' a key path to child state and 'action' a case key path to child action, instead. For more information see the following migration guide: https://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.5#Store-scoping-with-key-paths
stephencelis commented 3 months ago

@woxtu Thanks for looking into this! While we do want to revisit updating our benchmarks in the future, for now these benchmarks explicitly intend to test the old, uncached stores, so those deprecations are OK for now. We appreciate you taking the time to try to fix, though!