search

pointfreeco / swift-composable-architecture

A library for building applications in a consistent and understandable way, with composition, testing, and ergonomics in mind.
https://www.pointfree.co/collections/composable-architecture
MIT License
12.22k stars 1.42k forks source link

Shared: Update `XCTFail` to `reportIssue` #3258

Closed stephencelis closed 1 month ago

stephencelis commented 1 month ago

Another fix for a symbol mentioned in https://github.com/pointfreeco/swift-issue-reporting/issues/100

ryanmeisters commented 1 month ago

is there a planned release for this one? 🙏🏼 😇

mbrandonw commented 1 month ago

Hi @ryanmeisters, this was already released as 1.12, but be sure to target 1.12.1 because we had a small fix right after the 1.12 release.

ryanmeisters commented 1 month ago

Oh I think Stephen added this after the 1.12.1 release in response to this comment, right?

mbrandonw commented 1 month ago

Oh sorry, no this specific commit has not yet been released yet. We can cut a 1.12.2 soon.

ryanmeisters commented 4 weeks ago

bump 😇 ❤️

stephencelis commented 4 weeks ago

@ryanmeisters This PR should be mostly cosmetic, as issue reporting's XCTFail unconditionally reports issues to both XCTest and Testing. Are you experiencing a particular issue?

ryanmeisters commented 4 weeks ago

Ah yeah I think this was the fix for our issue here.

Honestly not a huge deal if it's high effort to make a patch release. To solve it for us I temporarily pinned all the tca dependencies to the XCTestDyanmicOverlay versions. I was just trying to keep track of when I could undo that and get back to current versions.

stephencelis commented 4 weeks ago

Ah, sorry, I forgot about the symbol-related issue. We're planning a minor release with the new UIKit navigation tools this week, so when that's out it will get this patch. Thanks for your patience!