search

pointfreeco / swift-composable-architecture

A library for building applications in a consistent and understandable way, with composition, testing, and ergonomics in mind.
https://www.pointfree.co/collections/composable-architecture
MIT License
12.35k stars 1.44k forks source link

StandupsListTest crashes #3335

Closed easiwriter closed 1 month ago

easiwriter commented 1 month ago

Description

Running StandupsListTest crashes consistently at line 521 of the extension to OrderedSet. It looks to me as though some code is missing from the guard statement because when _elements has zero items it attempts to remove item[0].

Checklist

Expected behavior

I'd expect the test to complete normally

Actual behavior

It crashes as described above

Steps to reproduce

Just run the test

The Composable Architecture version information

1.14.0

Destination operating system

IOS 17

Xcode version information

Xcode 15.5

Swift Compiler version information

SWift 5
mbrandonw commented 1 month ago

Hi @easiwriter, I am not able to reproduce this. It passes just fine for me:

image

And fwiw, these tests run on CI with every PR and they have been passing for a long time. Can you provide some proof of the crash?

I'm not sure this is an issue with the library, and so for now I am going to convert it to a discussion. Feel free to continue the conversation over there.