pointfreeco / swift-custom-dump

A collection of tools for debugging, diffing, and testing your application's data structures.
MIT License
800 stars 89 forks source link

Turn on Swift 6 language mode. #123

Closed mbrandonw closed 2 months ago

mbrandonw commented 3 months ago

There was only one small thing stopping us from turning on Swift 6 mode in this package, and that was our use of a data bytes formatter. It may be OK to just nonisolated(unsafe) it since the initialization of static variables is thread safe in Swift and since we never mutate the formatter after initialization. But I went ahead and wrapped it in a lock too just in case.

Alternatively we could use the new FormatStyle stuff, but then the CustomDumpStringConvertible conformance will be iOS 15+ (probably not a big deal), but also I don't think FormatStyle is implemented in corelibs-foundation.