pointfreeco / swift-custom-dump

A collection of tools for debugging, diffing, and testing your application's data structures.
MIT License
800 stars 89 forks source link

UNNotificationPresentationOptions [.banner, .list] workaround #30

Closed jaanussiim closed 2 years ago

jaanussiim commented 2 years ago

Xcode 13.2 introduced a new build system that seems to have troubles with availability checks in getters.

https://developer.apple.com/documentation/xcode-release-notes/xcode-13_2-release-notes

Seeing ~30% speedup with this setting, it's kind of a bummer it can't be turned on with projects using TCA 😞

Moving the check out of the getter fixes the compile issue.

This solution may not be the PointFree way 😸

jaanussiim commented 2 years ago

Twitter thread where this issue was discussed

https://twitter.com/BenchR/status/1460699068846456832

Looks it did not get fixed for RC

DanKorkelia commented 2 years ago

Hey, I opened an issue 1 hour before this PR and now closed it. But wondering when will this change propagate to TCA? Will there be a 0.29.1 release?

stephencelis commented 2 years ago

@DanKorkelia You can use the existing 0.29.0 release with the updated swift-custom-dump today. You just need to run SPM's update functionality.

DanKorkelia commented 2 years ago

Thank you. That is exactly what I've done.