search

pointfreeco / swift-custom-dump

A collection of tools for debugging, diffing, and testing your application's data structures.
MIT License
800 stars 89 forks source link

Show label for visited items #43

Closed brentleyjones closed 2 years ago

brentleyjones commented 2 years ago

Friendly ping @stephencelis @mbrandonw

mbrandonw commented 2 years ago

Hi @brentleyjones, do you have any info on what motivated this change and how it changes the output of customDump? It doesn't seem to affect the output of any our tests, so we're having a hard time understanding.

brentleyjones commented 2 years ago

Yes. Before this change, when dumping a class that has a property on an object, and then one of its properties also has a property on the same object, currently the output won't show the property name for the "skipped" (already visited) property.

mbrandonw commented 2 years ago

@brentleyjones Would it be possible to write a test case that shows this behavior?

brentleyjones commented 2 years ago

Will do!

brentleyjones commented 2 years ago

Test added. It fails without the changes in the PR.

brentleyjones commented 2 years ago

@mbrandonw