search

pointfreeco / swift-issue-reporting

Report issues in your application and library code as Xcode runtime warnings, breakpoints, assertions, and do so in a testable manner.
https://www.pointfree.co
MIT License
368 stars 60 forks source link

`unimplemented` without `Void` placeholder produces deprecation warning #122

Closed hyperspacemark closed 1 week ago

hyperspacemark commented 3 weeks ago

The following declaration produces a deprecation warning on the Swift 6 language mode only. I'm aware that the placeholder-less methods were deprecated but this seems to have only appeared after #114 was released.

var onCancel: () -> Void = unimplemented("ViewModel.onCancel") // warning: 'unimplemented(_:file:fileID:function:line:)' is deprecated: renamed to 'unimplemented(_:placeholder:)'

I can of course resolve the warning with the following but I don't think the intention is that this is necessary.

var onCancel: () -> Void = unimplemented("ViewModel.onCancel", placeholder: ())
stephencelis commented 1 week ago

This should be fixed by #123! We'll do a release soon.