Turn on strict concurrency.

pointfreeco / swift-perception

Observable tools, backported.

MIT License

574 stars 43 forks source link

Turn on strict concurrency. #57

Closed mbrandonw closed 7 months ago

Brett-Best commented 7 months ago

Might be worth turning on GlobalConcurrency too?

mbrandonw commented 7 months ago

Hi @Brett-Best, thanks for the suggestion! I can definitely add that, but it also seems to be a subset of StrictConcurrency as far as I can tell. I get the global mutable state warning when only StrictConcurrency is specified in Package.swift.

Are you aware of anything that GlobalConcurrency surfaces that is not covered by StrictConcurrency?

Brett-Best commented 7 months ago

Ah, looks like it's enabled implicitly when StrictConcurrency is on 😅 https://github.com/apple/swift/blob/17ca88c94a34b34c3c354891e899e82ce98f46ee/lib/Frontend/CompilerInvocation.cpp#L979-L983