search

pointfreeco / swift-snapshot-testing

📸 Delightful Swift snapshot testing.
https://www.pointfree.co/episodes/ep41-a-tour-of-snapshot-testing
MIT License
3.79k stars 581 forks source link

Improve wkWebView.takeSnapshot with Xcode 14 and Xcode 15 #692

Closed teameh closed 10 months ago

teameh commented 1 year ago

This will improve https://github.com/pointfreeco/swift-snapshot-testing/issues/625 a bit.

Without this patch snapshots crash, with this patch, only the background color of the webview is snapped.

teameh commented 1 year ago

@stephencelis @mbrandonw anything I can do to help moving this forward? :)

teameh commented 1 year ago

@Sherlouk thanks for the review!

@stephencelis @mbrandonw anything we can do to move this forward and get this released so we can start using Xcode 14?

teameh commented 1 year ago

Ping @stephencelis @mbrandonw :)

teameh commented 1 year ago

@Sherlouk, @stephencelis & @mbrandonw our app is still using my fork of this project so we can use XCode 14. There must be more devs with this problem... Can we get this merged :)?

Sherlouk commented 1 year ago

Not on me I'm afraid, but I agree it'd be nice to see it merged.

teameh commented 1 year ago

Haha indeed. Thanks! Fixed

teameh commented 1 year ago

@stephencelis @mbrandonw I've merged main again. Anything else I can do to help get this merged?

jeroendeleeuw commented 10 months ago

@teameh Would you like to merge main in again? I do not have the access rights to do it myself.

teameh commented 10 months ago

Done @jeroendeleeuw.

mat1th commented 10 months ago

What is needed to get this fix merged? I'm using this branch already a while and the snapshots of web views are stable for me.

teameh commented 10 months ago

Thanks @stephencelis!