pointfreeco / swift-snapshot-testing

📸 Delightful Swift snapshot testing.
https://www.pointfree.co/episodes/ep41-a-tour-of-snapshot-testing
MIT License
3.73k stars 565 forks source link

Enhancements to `diffTool`? #780

Closed JackYoustra closed 1 month ago

JackYoustra commented 11 months ago

My current workflow for image snapshot tests is usually imagemagik's compare tool, so I'll have a command like

compare "1.png" "2.png" png:- | open -a Preview.app -f

Unfortunately, the framework only lets me specify the "compare" step instead of providing the rest of the command. I was thinking on changing / adding a closure version of diffTool that'd be able to do this. Is there any interest in this or any ideas on how people would like a more generalized diffTool?

tisohjung commented 10 months ago

I would appreciate it if anyone can review this PR

https://github.com/pointfreeco/swift-snapshot-testing/pull/668

endanke commented 7 months ago

@JackYoustra you can probably make an alias to your command which would take the two parameters and run the whole thing.

mbrandonw commented 1 month ago

Closed via #867.