search

pointhi / kicad-footprint-generator

creating kicad footprints using python scripts
GNU General Public License v3.0
185 stars 175 forks source link

make_TerminalBlock_Phoenix.py does not generate names for mounting pads #220

Open tolot27 opened 5 years ago

tolot27 commented 5 years ago

See https://github.com/KiCad/kicad-footprints/issues/1087.

tolot27 commented 5 years ago

Unfortunately, make_TerminalBlock_Phoenix.py does not generate the footprints of the PTSM SMD versions, only the THR versions. How they are generated?

tolot27 commented 5 years ago

I'd like to continue with library development. Therefore, it would be great to know if the latest version is committed and pushed. Currently, it does not seem to be the case.

Also, /tree/master/scripts/Resistors_SMD has an old name (should be singular Resistor_SMD) and the README.md inside also contains the plural version. That lead me to the assumption that the most recent version is not pushed.

Indeed, I can create PRs for that but I'd like to be sure...

evanshultz commented 5 years ago

Tracking this down is just a matter of using the Git history. In fact, you can do all of this on your own using the web interface. I'll write it out step-by-step so you can do the same in the future.

  1. Browse to one of the SMD footprints you're interested in. Let's go with https://github.com/KiCad/kicad-footprints/blob/master/TerminalBlock_Phoenix.pretty/TerminalBlock_Phoenix_PTSM-0%2C5-2-2%2C5-V-SMD_1x02_P2.50mm_Vertical.kicad_mod.
  2. At the top, you can see that @jkriege2 added them at https://github.com/KiCad/kicad-footprints/pull/37 (commit https://github.com/KiCad/kicad-footprints/pull/37/commits/0b107f7776bb49555b95bccc63b1937518656215).
  3. That commit helpfully points out the footprints were copied from the old library at https://github.com/KiCad/Connectors_Phoenix.pretty.
  4. Commits adding the SMD PTSM footprints were at https://github.com/KiCad/Connectors_Phoenix.pretty/pull/42 and https://github.com/KiCad/Connectors_Phoenix.pretty/pull/43.
  5. Those PRs asked if the footprints were scripted but there was no answer to that so I suspect they were hand made.

Therefore, we likely don't have a script for PTSM SMD variants but it would be nice to add them. You may be able to adapt https://github.com/pointhi/kicad-footprint-generator/tree/master/scripts/Connector/Connector_SMD_single_row_plus_mounting_pad to work (I didn't check myself but that is the preferred way if possible).

For resistors, a file in the Resistors_SMD directory instructs the user to go to https://github.com/pointhi/kicad-footprint-generator/tree/master/scripts/SMD_chip_package_rlc-etc where the current (and much better) generator is located.

tolot27 commented 5 years ago

Just not to forget renaming the package: KiCad/kicad-footprints/issues/1140