pointhi / kicad-footprint-generator

creating kicad footprints using python scripts
GNU General Public License v3.0
186 stars 175 forks source link

add updated script from MSOP10 #614

Closed lukh closed 3 years ago

lukh commented 3 years ago

Providing HVSSOP yaml settings for https://github.com/KiCad/kicad-symbols/pull/2717

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit b60fcc93 and detected 0 issues on this pull request.

View more on Code Climate.

cpresser commented 3 years ago

Related: https://github.com/KiCad/kicad-footprints/pull/2460

Datasheet: https://www.ti.com/lit/ds/symlink/bq24090.pdf

lukh commented 3 years ago

Hi, thank for the help; a general remark based on yours, The work here is mainly based on the MSOP-10 package, regarding this " Very Thin Shrink Small Outline Package, also referred as MSOP = Micro Small Outline Package " (https://www.ti.com/support-packaging/packaging-resources/packaging-terminology.html)

And the fact that the component designed (https://github.com/KiCad/kicad-symbols/pull/2717), in its first revision, was using the MSOP-10 package, with sucess.

I work on the specific points now ! Bests,

cpresser commented 3 years ago

Hi, sorry for all the fuzz, I guess from your point of view that is pretty ridiculous.

The work here is mainly based on the MSOP-10 package, regarding this " Very Thin Shrink Small Outline Package, also referred as MSOP = Micro Small Outline Package " (https://www.ti.com/support-packaging/packaging-resources/packaging-terminology.html)

And the fact that the component designed (KiCad/kicad-symbols#2717), in its first revision, was using the MSOP-10 package, with sucess.

There are two reasons why I am picky here:

  1. Consistency. People looking at this in the future should not ask themselves why some dimensions differ from the datasheet. Also, why make a new footprint if its the same as the existing one?
  2. We want footprints to be as good as possible - to maximize yield in automated production lines.

Anyway, I like you changes. There is just one thing I still don't understand. Why the line

grid: [1.1, 1.3]

What does it do?

lukh commented 3 years ago

Hi, No problems at all ! It is a good thing :+1:

Ok the grid apply a coefficient to dimensions of the back pad of EP. I remove it.

cpresser commented 3 years ago

Looks good. Thanks!