pointhi / kicad-footprint-generator

creating kicad footprints using python scripts
GNU General Public License v3.0
186 stars 175 forks source link

Add 205338 series SMT RA header for Molex Pico-Lock (2mm pitch) family #625

Open justyn opened 3 years ago

justyn commented 3 years ago

This PR adds the PCB headers for the 2mm pitch version of the Molex Pico-Lock family (manufacturer page).

Currently the section "PicoLock_side_entry" in conn_molex.yaml covers only the 1.5mm pitch versions.

For the values I started with the existing 1.5mm PicoLock_side_entry values then updated them using a combination of:

I then made some minor manual adjustments to the outline so that it fit more evenly around the edge of the connector when the 3D model was added.

See the below images of 3D model superimposed on the footprint, deliberately intersecting to show alignment. Note that the top and bottom of the connector are different sizes so the body outline covers the extent. The lower image shows the model flipped so that the bottom of the connector can be compared to the outline.

datasheet

image

image

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit 7ebaacc3 and detected 0 issues on this pull request.

View more on Code Climate.

Werni2A commented 3 years ago

Hi @justyn nice work but shouldn't the pin numbering be inversed?

The datasheet shows pin (circuit) 1 on the rigth in top view whereas in your footprint pin 1 is on the left in top view. image image

justyn commented 3 years ago

@Werni2A that is a great point, I can't believe I didn't spot that.

However, the same applies to the existing 1.5mm Pico-Lock 504050 parts. Their pin numbering is also reversed (see images below).

If we add the 2.0mm pitch versions with the correct pin numbering it would be pretty inconsistent with the 1.5mm version. We presumably can't change the pin numbering on the existing footprints because it would break existing designs.

What is done in this situation? Add a new set of footprints for the 1.5mm versions with the numbering corrected, existing alongside the originals?

image image

Werni2A commented 3 years ago

That's a good point. I think the existing footprints should be corrected. Because of the breaking change it might be possible for Kicad V6 but I'm not a librarian, so it's up to them to decide.

justyn commented 3 years ago

I've tentatively pushed a new commit to fix the ordering on these (2mm) parts to match the datasheet, but probably a plan for the 1.5mm parts is needed before this is applied.

It would be pretty hellish to have two sizes of the Pico-Lock family with opposite pin numbering.

image

justyn commented 3 years ago

chschlue indicated that the incorrect ordering on the 1.5mm parts is a severe bug, I have submitted fixes to the script values here and the footprints here.

I assume then that this pull request for the 2mm parts can be merged (unless there are other issues).

justyn commented 3 years ago

I've updated the screenshots to reflect the new rotated footprints with fixed pin numbering.