pointonsoftware / pscore

C++ library for building your business software
GNU Affero General Public License v3.0
1 stars 2 forks source link

Addressed issues found in Codacy and LGTM #175

Closed gbenziv closed 3 years ago

gbenziv commented 3 years ago

Closes #171

Pull Request Checklist

codecov[bot] commented 3 years ago

Codecov Report

Merging #175 (86147eb) into master (aae0e5c) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files          37       37           
  Lines         724      724           
=======================================
  Hits          685      685           
  Misses         39       39           
Impacted Files Coverage Δ
core/entity/employee.hpp 100.00% <ø> (ø)
core/entity/user.hpp 100.00% <ø> (ø)
core/domain/employeemgmt/employeecontroller.cpp 96.36% <100.00%> (ø)
core/domain/userlogin/logincontroller.cpp 92.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6d9519...86147eb. Read the comment docs.