pointonsoftware / pscore

C++ library for building your business software
GNU Affero General Public License v3.0
1 stars 2 forks source link

Changed validation result type from std::unordered_map to std::map #180

Closed gbenziv closed 3 years ago

gbenziv commented 3 years ago

Closes #179

Pull Request Checklist

codecov[bot] commented 3 years ago

Codecov Report

Merging #180 (5ab08c4) into master (a933054) will decrease coverage by 4.99%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   94.61%   89.61%   -5.00%     
==========================================
  Files          37       43       +6     
  Lines         724      780      +56     
==========================================
+ Hits          685      699      +14     
- Misses         39       81      +42     
Impacted Files Coverage Δ
core/entity/customer.hpp 0.00% <0.00%> (ø)
core/entity/employee.hpp 100.00% <ø> (ø)
core/validator/validator.hpp 100.00% <ø> (ø)
...ore/domain/customermgmt/customermgmtcontroller.cpp 8.57% <8.57%> (ø)
...nittest/mock/customermgmt/customermgmtdatamock.hpp 33.33% <33.33%> (ø)
...nittest/mock/customermgmt/customermgmtviewmock.hpp 40.00% <40.00%> (ø)
...ore/domain/customermgmt/customermgmtcontroller.hpp 100.00% <100.00%> (ø)
core/domain/employeemgmt/employeecontroller.cpp 96.36% <100.00%> (ø)
core/domain/inventory/inventorycontroller.cpp 95.71% <100.00%> (ø)
core/domain/unittest/test_customermgmt.cpp 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86a8d61...22030e7. Read the comment docs.