Closed gbenziv closed 3 years ago
Merging #200 (2ef5d24) into master (ed97599) will increase coverage by
0.23%
. The diff coverage is95.94%
.
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 95.33% 95.56% +0.23%
==========================================
Files 45 51 +6
Lines 900 1037 +137
==========================================
+ Hits 858 991 +133
- Misses 42 46 +4
Impacted Files | Coverage Δ | |
---|---|---|
core/domain/common/cachecontroller.hpp | 100.00% <ø> (ø) |
|
...omain/customermgmt/interface/customermgmtiface.hpp | 100.00% <ø> (ø) |
|
core/domain/dashboard/interface/dashboardiface.hpp | 100.00% <ø> (ø) |
|
core/domain/inventory/interface/inventoryiface.hpp | 100.00% <ø> (ø) |
|
core/domain/inventory/inventorycontroller.hpp | 100.00% <ø> (ø) |
|
core/domain/userlogin/interface/loginiface.hpp | 100.00% <ø> (ø) |
|
core/entity/employee.hpp | 100.00% <ø> (ø) |
|
core/validator/productvalidator.hpp | 100.00% <ø> (ø) |
|
core/domain/unittest/test_inventory.cpp | 96.66% <93.18%> (-3.34%) |
:arrow_down: |
core/domain/common/basecontroller.hpp | 100.00% <100.00%> (ø) |
|
... and 13 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a2eab60...2ef5d24. Read the comment docs.
xxxx
Since the dp and view instances were moved to the basecontroller, it would make sense for the null-check to be in that class as well.
Pull Request Checklist