pointonsoftware / pscore

C++ library for building your business software
GNU Affero General Public License v3.0
1 stars 2 forks source link

Created Accounting API and stubs #227

Closed gbenziv closed 3 years ago

gbenziv commented 3 years ago

xxxx

Pull Request Checklist

codecov[bot] commented 3 years ago

Codecov Report

Merging #227 (6025391) into master (0fbfdcb) will decrease coverage by 1.32%. The diff coverage is 42.42%.

:exclamation: Current head 6025391 differs from pull request most recent head 072f640. Consider uploading reports for the commit 072f640 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   95.42%   94.10%   -1.33%     
==========================================
  Files          63       63              
  Lines        1137     1153      +16     
==========================================
  Hits         1085     1085              
- Misses         52       68      +16     
Impacted Files Coverage Δ
core/domain/accounting/salecomputer.hpp 100.00% <ø> (ø)
core/domain/unittest/test_salecomputer.cpp 100.00% <ø> (ø)
core/domain/accounting/accountingcontroller.cpp 19.04% <15.00%> (ø)
...in/unittest/mock/accounting/accountingdatamock.hpp 50.00% <50.00%> (ø)
core/domain/accounting/accountingcontroller.hpp 100.00% <100.00%> (ø)
...re/domain/accounting/interface/accountingiface.hpp 100.00% <100.00%> (ø)
core/domain/accounting/salecomputer.cpp 100.00% <100.00%> (ø)
...in/unittest/mock/accounting/accountingviewmock.hpp 100.00% <100.00%> (ø)
core/domain/unittest/test_accounting.cpp 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fbfdcb...072f640. Read the comment docs.

gbenziv commented 3 years ago

core/domain/common/types.hpp#L39 struct member 'TodaySalesSummary::targetDiffPercentage' is never used.

these unused variable is placed ahead and will be used by the dashboard APIs