Closed syedmalimustafa closed 3 years ago
Merging #240 (5138ef9) into master (9f05930) will increase coverage by
0.14%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 94.89% 95.04% +0.14%
==========================================
Files 65 65
Lines 1234 1271 +37
==========================================
+ Hits 1171 1208 +37
Misses 63 63
Impacted Files | Coverage Δ | |
---|---|---|
core/domain/accounting/accountingcontroller.cpp | 81.96% <ø> (ø) |
|
core/domain/inventory/interface/inventoryiface.hpp | 100.00% <ø> (ø) |
|
core/domain/inventory/inventorycontroller.hpp | 100.00% <ø> (ø) |
|
core/validator/productvalidator.hpp | 100.00% <ø> (ø) |
|
utility/datetime/datetime.hpp | 100.00% <ø> (ø) |
|
core/domain/employeemgmt/employeecontroller.cpp | 95.95% <100.00%> (ø) |
|
core/domain/inventory/inventorycontroller.cpp | 98.16% <100.00%> (+0.29%) |
:arrow_up: |
...main/unittest/mock/inventory/inventorydatamock.hpp | 100.00% <100.00%> (ø) |
|
core/domain/unittest/test_accounting.cpp | 95.23% <100.00%> (ø) |
|
core/domain/unittest/test_inventory.cpp | 96.98% <100.00%> (+0.31%) |
:arrow_up: |
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 93ac172...5138ef9. Read the comment docs.
@alimustafashah , not sure if this is ready for review.. if it is, you may need to look through the areas indicated in https://github.com/pointonsoftware/pscore/issues/238#issuecomment-850919711 to make sure we covered everything
kindly add a reviewer and the "Ready for review" label as well when this is ready
I changed it all places where a timestamp was written, I did not change the birthday format. Can you elaborate?
I changed it all places where a timestamp was written, I did not change the birthday format. Can you elaborate?
right, birthday format shouldn't be changed. thanks
thank you @alimustafashah. your changes are now merged to master
Pull Request Checklist