Closed dstufft closed 10 years ago
Hey @dstufft! Thank you for supporting the Opscode Cookbooks! Our process has a couple prerequisites before we can merge your contribution. We need to ensure you've completed a Contributor License Agreement (CLA) and a ticket on our ticket tracker for the release workflow. Pull requests are optional, but should always include the ticket number that they're related to for cross-referencing. Please take a moment to review the below wiki page for the appropriate steps:
Also, it looks like this will not merge cleanly. Could yo please rebase off master?
Pretty sure i've signed a CLA, this was months ago so I could be remembering wrong.
I can rebase it this week sometime.
The new hosts
attribute should probably be documented in the README.
Not gonna lie I'm not sure if i'll get time to do this or not :( Some stuff came up, if someone else wants to take it over that's fine with me.
What needs doing to get this merged/released, @sethvargo?
@someara ^
Docs pull request coming right up.
Anything more I can do to get this merged quicker?
+1 for being able to run tests on Vagrant. This is a huge blocker.
+1
@coderanger #13 is redundant without this being merged.
Oh hah, I thought this was merged long ago.
Any chance this could be included in a swift release to the community site, @coderanger?
@coderanger Do you need a co-maintainer to assist with the review/merge/release process? Frankly I'm dying for this to be included in a release.
https://tickets.opscode.com/browse/COOK-3254
A continuation of #8 that moves the logic into the provider.