poise / application_nginx

Development repository for Opscode Cookbook application_nginx
Apache License 2.0
34 stars 55 forks source link

[COOK-3254] Allow app_nginx to work under solo #11

Closed dstufft closed 10 years ago

dstufft commented 11 years ago

https://tickets.opscode.com/browse/COOK-3254

A continuation of #8 that moves the logic into the provider.

sethvargo commented 11 years ago

Hey @dstufft! Thank you for supporting the Opscode Cookbooks! Our process has a couple prerequisites before we can merge your contribution. We need to ensure you've completed a Contributor License Agreement (CLA) and a ticket on our ticket tracker for the release workflow. Pull requests are optional, but should always include the ticket number that they're related to for cross-referencing. Please take a moment to review the below wiki page for the appropriate steps:

Also, it looks like this will not merge cleanly. Could yo please rebase off master?

dstufft commented 11 years ago

Pretty sure i've signed a CLA, this was months ago so I could be remembering wrong.

I can rebase it this week sometime.

cjerdonek commented 11 years ago

The new hosts attribute should probably be documented in the README.

dstufft commented 11 years ago

Not gonna lie I'm not sure if i'll get time to do this or not :( Some stuff came up, if someone else wants to take it over that's fine with me.

benlangfeld commented 10 years ago

What needs doing to get this merged/released, @sethvargo?

sethvargo commented 10 years ago

@someara ^

benlangfeld commented 10 years ago

Docs pull request coming right up.

benlangfeld commented 10 years ago

Anything more I can do to get this merged quicker?

lpradovera commented 10 years ago

+1 for being able to run tests on Vagrant. This is a huge blocker.

sashich commented 10 years ago

+1

benlangfeld commented 10 years ago

@coderanger #13 is redundant without this being merged.

coderanger commented 10 years ago

Oh hah, I thought this was merged long ago.

benlangfeld commented 10 years ago

Any chance this could be included in a swift release to the community site, @coderanger?

benlangfeld commented 10 years ago

@coderanger Do you need a co-maintainer to assist with the review/merge/release process? Frankly I'm dying for this to be included in a release.