poise / halite

Write as a gem, release as a cookbook.
https://github.com/poise/halite
Apache License 2.0
42 stars 9 forks source link

update bundler and rubygems #3

Closed lamont-granquist closed 8 years ago

lamont-granquist commented 8 years ago

i believe this'll fail on travis...

coderanger commented 8 years ago

What's the goal? Halite depends on Bundler so if there is a specific version I should depend on it directly.

lamont-granquist commented 8 years ago

Yeah, it looks like halite isn't compatible with the latest bundler+rubygems -- this is failing in travis...

There's an override in the chef/chef tests that have been making it pass by keeping the default travis versions, but i need to bump that to 1.10.0 or later for the gem metadata stuff and add a chef runtime dep on bundler now...

coderanger commented 8 years ago

Got it, thanky :)

coderanger commented 8 years ago

Hmm, the only test that is failing is a failure of the test harness, not Halite itself. Will have to dig in a bit.

lamont-granquist commented 8 years ago

:+1:

coderanger commented 8 years ago

Testing against multiple bundler/rubygems versions is complicated by the fact that env vars are not part of the travis cache key still (I think).

lamont-granquist commented 8 years ago

Yeah chef/chef is running against the latest versions for most of the tests, except for a couple where they got overridden either accidentally or like with halite it looks like it was done on purpose. I'll have to change it so we're running against latest for all the chef/chef travis tests... Probably halite and friends should test against latest as well...

coderanger commented 8 years ago

Running with the Rubygems that comes out of the box is a feature, so I'll have to add specific tests to the matrix for this.