sebdalgarno
commented
1 month ago - https://github.com/poissonconsulting/bbou-internal/issues/16
- sped up tests by only testing model fitting once per method/type and checking that model constructed correctly for variations on each model
- https://github.com/poissonconsulting/bbou-internal/issues/18
- unable to resolve - can't remove skip_covr() lines because still running into model create issue on code covr (test dont fail on CI)
- https://github.com/poissonconsulting/bbou-internal/issues/23
- done
- https://github.com/poissonconsulting/bbou-internal/issues/19
- done. store start_year as attribute and provide warning to user if try to use predict_growth function when survival and recruitment model fits have different start_year.
- https://github.com/poissonconsulting/bbou-internal/issues/30
- https://github.com/poissonconsulting/bbou-internal/issues/24
- only skipping ML snapshot test on windows
- https://github.com/poissonconsulting/bbou-internal/issues/42
- rethink how convergence treated. now converged = TRUE by default if rhat <= 1.05... does not check ess
- user has option to change max rhat in glance and converged functions