poissonconsulting / chk

An R package for developers to check user-supplied function arguments
https://poissonconsulting.github.io/chk/
Other
48 stars 4 forks source link

`chk_url`? #126

Closed NewGraphEnvironment closed 7 months ago

NewGraphEnvironment commented 8 months ago

Guessing this is not the package for a function that checks to see if a url is valid if it would introduce more dependencies (ex. httr)?

See details at https://github.com/NewGraphEnvironment/rfp/issues/2

might be ways around the dependency too I guess. If so - is this the place for this?

Loving chk - thank you!

joethorley commented 8 months ago

@NewGraphEnvironment - glad you are liking it. It would be a cool function. It could potentially be a chk::check_xx() function with httr just in suggest. We'll think on it.

joethorley commented 7 months ago

We've discussed as a team and its not straightforward to check if a url is valid because its possible to "connect" to any url whether or not it exists (consider url("https://www.oueou")) and often one a url may no longer be valid but the website will serve up a 404 page. So unless we can come up with a quick and simple test I think it will add to much complexity to the package.

NewGraphEnvironment commented 7 months ago

Ah - good points! Thanks for considering and responding