Open sebdalgarno opened 1 year ago
This behaviour does match the intention of the function since a vector of strings is passed there is no way to tell whether the value should be PST or PDT if the values are independent (not a series). This means that the PST or PDT needs to be assigned consistently to string values and it appears that "2021-11-07 1:00:00" is coded with PDT and "2021-11-07 2:00:00" is coded with PST. This is unfortunately a limitation but is unavoidable when converting a string based on how time/timezones/daylight savings works.
This scenario can be common with various types of data and so users need to be aware of this issue.
Potential work arounds could be
1) a function that can detect when this occurs in a data set so a person can manually make the change and confirm it was done correctly 2) a function that can identify and make the correction
I ran into this issue while converting a real world discharge data set that was provided in PST8PDT (i.e. two 1:00:00 entries on November 07 2021). I had to manually change the second 1:00:00 entry prior to adjusting tz, which doesn't seem right...