search

poissonconsulting / fish-passage-22

0 stars 1 forks source link

Read discharge pcic #15

Closed NewGraphEnvironment closed 6 months ago

NewGraphEnvironment commented 6 months ago

oh wow. what a journey!!

read-discharge-pcic.R calls pcic_dl_sh function to build bash file that can be run with bash pcic_dl.sh on commandline. Is computer specific b/c of S P A C E in the name of our shared dropbox folder 😲 . So to recreate the .nc files on dropbox you should rebuild the pcic_dl.sh file with read-discharge-pcic.R

Apparently - according to comments in bcfishpass Makefile we:

Add baseflow and runoff to create discharge.

Not sure if we can/should do that first as it was done after getting averages in bcfishpass. Wouldn't think it would matter but did not add yet in case.

Tried to retrieve data by makeing a Makefile to run as per the methods in bcfishpass but uncovered this issue https://github.com/smnorris/bcfishpass/issues/452

NewGraphEnvironment commented 6 months ago

@nehill197 - i'll leave it to you to merge in case there is something here that messes with your overall workflows. Let me know if the data seems all good. I chose the ACCESS1-0_rcp85 model b/c it has only one output and high emmissions scenario shouldn't matter for our time series but I think we can download any of the models and scenarios from https://data.pacificclimate.org/portal/hydro_model_out/catalog/catalog.json with pcic_dl_sh()

nehill197 commented 6 months ago

Great work, thanks so much Al!!