Add parks pacific marine fish codes

poissonconsulting / fishbc

An R package of Fish Codes for British Columbia

https://poissonconsulting.github.io/fishbc/

Creative Commons Attribution 4.0 International

5 stars 3 forks source link

Add parks pacific marine fish codes #10

Open aylapear opened 2 years ago

aylapear commented 2 years ago

Your Idea

Add the fish codes from the Parks Canada marine study to the package
Add Lynn Lee as contributor

aylapear commented 2 years ago

I suggest adding the new table as marineparks

@evanamiesgalonski & @joethorley What do you think the new table name should be?

aylapear commented 2 years ago

We assume the codes should be added to the freshwaterfish as a crossrefence (like the CDCode and ABCode columns) for the ones that span both tables like salmon. Do you agree @evanamiesgalonski ?

evanamiesgalonski commented 2 years ago

i think marineparksfish would be a good name for the new table. And yes I agree it would be good to have an FK column in freshwaterfish to join to the new table.

joethorley commented 2 years ago

Yes agree with adding a FK to freshwater fish for where they match up.

joethorley commented 2 years ago

Our other tables are called ab and cdc so pc would be most fitting but they may have codes for freshwater - so how about pcmarine?

Alcon98 commented 2 years ago

Oh I like the way that sounds, really rolls off the tongue