search

poissonconsulting / fwapgr

An R Client for BC Freshwater Atlas Web API
https://poissonconsulting.github.io/fwapgr
Other
8 stars 1 forks source link

check valid collectionid #31

Closed sebdalgarno closed 3 years ago

sebdalgarno commented 3 years ago

from list of collections in test-metadata

sebdalgarno commented 3 years ago

should make vector of collectionids internal data?

sebdalgarno commented 3 years ago

is it possible to make daily updates of internal data via Actions? That way we could ensure collection_id lookup is always up-to-date

joethorley commented 3 years ago

Yes this is totally possible - do you want to work on together on Friday or the weekend?

sebdalgarno commented 3 years ago

very cool. Yes let's work on it Friday. We could save the entire table from equivalent of fwa_meta_collections() daily..this would also speed up running fwa_meta_collections() as wouldn't need to query API

joethorley commented 3 years ago

Thinking about it some more I'm not sure we want to make it internal data or automatically update. Currently the test tests if something gets dropped but is fine with something being added. This is good behaviour - if we update it automatically then it won't give an error if something is dropped but we want to know about this. Also updating the version on GitHub won't update the table for users until they reinstall from GitHub which is not that often.

sebdalgarno commented 3 years ago

good points. Since this package is for power users I dont think we need to inform user if collection_id is incorrect (the API call will still fail)