poissonconsulting / fwapgr

An R Client for BC Freshwater Atlas Web API
https://poissonconsulting.github.io/fwapgr
Other
8 stars 1 forks source link

Missing collections? #43

Closed joethorley closed 3 years ago

joethorley commented 3 years ago

@smnorris - the following collections are missing - is this intentional?

 [1] "whse_fish.fiss_fish_obsrvtn_events_sp"    "whse_fish.fiss_fish_obsrvtn_pnt_distinct"
 [3] "whse_fish.fiss_fish_obsrvtn_pnt_sp"       "whse_fish.fiss_fish_obsrvtn_unmatched"   
 [5] "whse_fish.pscis_assessment_svw"           "whse_fish.pscis_design_proposal_svw"     
 [7] "whse_fish.pscis_events_barrier"           "whse_fish.pscis_habitat_confirmation_svw"
 [9] "whse_fish.pscis_points_all"               "whse_fish.pscis_remediation_svw"   
smnorris commented 3 years ago

Haven't loaded those yet. That was an oversight - I am going to need to create a checklist.

smnorris commented 3 years ago

No, a checklist isn't quite right - this is the opportunity to finally schedule these to run weekly.

smnorris commented 3 years ago

The observation data and source PSCIS tables are now loaded.

These two are not, they no longer exist: whse_fish.pscis_points_all, whse_fish.pscis_events_barrier. PSCIS scripts have been updated and integrated into bcfishpass - the pscis_points_all is still created but is not likely to be of much interest - the tables to use are bcfishpass.crossings and perhaps bcfishpass.pscis_not_matched_to_streams_vw to easily identify which PSCIS crossings don't get included in the crossings table. See https://github.com/smnorris/bcfishpass/tree/main/01_prep/barriers/04_pscis

(bcfishpass tables aren't loaded yet but should good to go in a few weeks)

joethorley commented 3 years ago

Great - thanks Simon!