Add gnis lookups - Githubissues

poissonconsulting / fwatlasbc

A R package to get data from the Freshwater Atlas of British Columbia

https://poissonconsulting.github.io/fwatlasbc/

Other

9 stars 0 forks source link

Add gnis lookups #37

Closed sebdalgarno closed 3 years ago

sebdalgarno commented 4 years ago

currently just uses named_streams layer to get valid gnis_name for stream_networks

sebdalgarno commented 4 years ago

glaciers_poly - gnis_name_1, gnis_name_2 bays_and_channels_poly - gnis_name wetlands_poly - gnis_name_1, gnis_name_2 islands_poly - gnis_name_1, gnis_name_2 named_streams - gnis_name rivers_poly - gnis_name_1, gnis_name_2

sebdalgarno commented 4 years ago

there is also the whse_basemapping.gns_geographical_names_sp collection - need to look into whether this is useful

smnorris commented 3 years ago

You should get fairly good results linking the two datasets but:

gnis names/errors will change/fixed but I'm not sure if the FWA features would similarly be updated if names change
the matching of gnis/trim names to FWA features was a detailed process, see the FWA docs for how they were related

That said, I'd use the gnis features direct from DataBC/bcdata rather than from hillcrestgeo - I'm maintaining the FWA features and fish passage related collections but that one was just something that seemed handy to add as a test.

joethorley commented 3 years ago

@sebdalgarno - what are you thinking of as use cases for this functionality? I'm wondering watershed areas grabs won't tackle it?

sebdalgarno commented 3 years ago

I think this is an artefact from before we shifted to watershed focus - likely can close