poissonconsulting / fwatlasbc

A R package to get data from the Freshwater Atlas of British Columbia
https://poissonconsulting.github.io/fwatlasbc/
Other
9 stars 0 forks source link

`test-add-collection-to-polygon` failing #71

Closed dunkenwg closed 1 month ago

dunkenwg commented 2 months ago
Failure (test-add-collection-to-polygon.R:54:3): fwa_add_collection_to_polygon function intersects work
x$geometry[[1]] inherits from 'XY'/'POINT'/'sfg' not 'LINESTRING'.

and

Failure (test-add-collection-to-polygon.R:55:3): fwa_add_collection_to_polygon function intersects work
colnames(sf::st_coordinates(x$geometry[[1]])) (`actual`) not identical to c("X", "Y", "L1") (`expected`).

`actual`:   "X" "Y"     
`expected`: "X" "Y" "L1"
dunkenwg commented 1 month ago

@joethorley, the first value in x$geometry is a POINT not a LINESTRING. If these tests are run on most other rows (row 2 for instance) they pass. How would you like me to handle this?

joethorley commented 1 month ago

done by not testing specifics of first value as the order can change.