search

poissonconsulting / mcmcr

An R package to manipulate MCMC samples
https://poissonconsulting.github.io/mcmcr/
Other
17 stars 2 forks source link

Failure with dev testthat #43

Closed hadley closed 4 years ago

hadley commented 4 years ago

I see:

── FAILURE (test-converged.R:11:3): converged.mcmcr ────────────────────────────
converged(mcmcr_example, by = "parameter", as_df = TRUE) not identical to structure(...).
Attributes: < Component "row.names": Modes: numeric, character >
Attributes: < Component "row.names": target is numeric, current is character >

── FAILURE (test-ess.R:23:3): ess.mcmcr as df ──────────────────────────────────
ess(mcmcr_example, as_df = TRUE, by = "parameter") not identical to structure(...).
Attributes: < Component "row.names": Modes: numeric, character >
Attributes: < Component "row.names": target is numeric, current is character >

Could you please take a look? I'm planning on submitting testthat to CRAN in about a month.

joethorley commented 4 years ago

I'm working on it!

joethorley commented 4 years ago

Done and pushed to CRAN as v0.4.0