Here’s what I think we do: 1) when the users passes the units as a text string when specifying a parameter we check if it is a recognized unit and throw an error if not
joe [4:35 PM]
2) when they then pass data if it doesn’t have the units specified in the data we just accept as is but if the units are specified we check they match
Yes cos then we know we can add future functionality
note because they can request data for multiple stations/parameters we shouldn’t set the units when they request data
because they can pass data for multiple stations they may not even be able to set the units which is why we accept if no units set
sebdalgarno
commented
6 years ago
Here’s what I think we do: 1) when the users passes the units as a text string when specifying a parameter we check if it is a recognized unit and throw an error if not
joe [4:35 PM] 2) when they then pass data if it doesn’t have the units specified in the data we just accept as is but if the units are specified we check they match Yes cos then we know we can add future functionality note because they can request data for multiple stations/parameters we shouldn’t set the units when they request data because they can pass data for multiple stations they may not even be able to set the units which is why we accept if no units set