poissonconsulting / ypr

An R package of equilibrium-based yield per recruit methods
https://poissonconsulting.github.io/ypr/
Other
7 stars 1 forks source link

ypr parameter load from .csv fails #44

Closed PAskey closed 4 years ago

PAskey commented 4 years ago

When loading the ypr parameters from a .csv with the online ShinyApp, the upload seems to occur, but parameters do not change. Running the app from R, and using the provided .csv template (with columns named "Parameter and"Value") I get the error message: Error : Column names in uploaded data must be 'Parameter' and 'Value'. Parsed with column specification: cols( Parameter = col_character(), Value = col_double(), Description = col_character() )

sebdalgarno commented 4 years ago

thanks for the bug report! it should be fixed now...both on the online app and from the R package. Please test and let me know...

PAskey commented 4 years ago

Hi Seb,

Thanks for getting back so quick. Still having the same issues.

Here is a .csv. I just took your template and changed some values.

Online – It indicates “upload complete”, but there is no change from defaults. From R I get the same error message as before.

Paul

From: Seb Dalgarno notifications@github.com Sent: July 2, 2020 6:57 PM To: poissonconsulting/ypr ypr@noreply.github.com Cc: Askey, Paul Paul.Askey@gofishbc.com; Author author@noreply.github.com Subject: Re: [poissonconsulting/ypr] ypr parameter load from .csv fails (#44)

thanks for the bug report! it should be fixed now...both on the online app and from the R package. Please test and let me know...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/poissonconsulting/ypr/issues/44#issuecomment-653291969, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADYOJE6K35H3GWDDAFS7WOLRZU3HDANCNFSM4OPCI2ZA.

sebdalgarno commented 4 years ago

hi @PAskey please try the online version now here https://poissonconsulting.shinyapps.io/ypr-shiny/

for testing the R package version please make sure you reinstall the package and restart your R session

PAskey commented 4 years ago

Thanks Seb,

Works now online and in R.

I installed the developmental versions of ypr and shinyypr. Is that the best option?

Paul

From: Seb Dalgarno notifications@github.com Sent: July 3, 2020 11:51 AM To: poissonconsulting/ypr ypr@noreply.github.com Cc: Askey, Paul Paul.Askey@gofishbc.com; Mention mention@noreply.github.com Subject: Re: [poissonconsulting/ypr] ypr parameter load from .csv fails (#44)

hi @PAskeyhttps://github.com/PAskey please try the online version now here https://poissonconsulting.shinyapps.io/ypr-shiny/

for testing the R package version please make sure you reinstall the package and restart your R session

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/poissonconsulting/ypr/issues/44#issuecomment-653648291, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADYOJEYBYAQJM5KL2MWKY4DRZYSCJANCNFSM4OPCI2ZA.

sebdalgarno commented 4 years ago

yes that is the best option - thanks!