search

poiuyqwert / PyMS

Broodwar Modding Suite
47 stars 18 forks source link

Fix off-by-ones in mapdata names #137

Closed neivv closed 1 year ago

neivv commented 1 year ago

The entry names for mapdata.dat were wrong, first one is a null entry, shifting everything down by one. And mapdata.tbl string IDs start from 1 with entry 0 being a null string, which is same as with portdata.tbl, images.tbl etc.

I've checked ingame that before this change, editing what was called "BW protoss02" to use "protoss05" path, ended up switching the first protoss mission to protoss04 instead. And FWIW, DatEdit has the same bug.

poiuyqwert commented 1 year ago

Thanks @neivv! Sorry I didn't notice this PR before (I feel like my notifications are not working on github or something). Would you be able to bump the PyDAT patch version in /PyMS/versions.json? If you can do that I can merge it directly, or I will wait until I have a moment where I will be able to update the version file myself before I merge it.

Thanks again!

neivv commented 1 year ago

Sure, done

poiuyqwert commented 1 year ago

Thanks @neivv ❤️