More updates related to mapdata fix

poiuyqwert / PyMS

Broodwar Modding Suite

47 stars 18 forks source link

More updates related to mapdata fix #141

Closed poiuyqwert closed 1 year ago

poiuyqwert commented 1 year ago

Update map 0 data name to "No map"
Fix mapdata.tbl offset in DATEntryName
Update test_entry_names for mapdata fix

poiuyqwert commented 1 year ago

Hey @neivv, are you able to do a quick sanity check on this? This slight off by 1 in multiple places just really confuses me lol. Thank you 🙏

neivv commented 1 year ago

Yea these are now correct, sorry for not noticing that you had tests for these.

Also, not exactly mapdata changes, but the offset parameter on DATEntryName._entry_label seems useless? Only user left now is portdata and there it also appears to be off by one? With the way strings in portdata.tbl are laid out, with default files it just gets talking portrait name instead idle name, but nevertheless.

poiuyqwert commented 1 year ago

Good catch, there were even some other issues with the portrait tests caused by that. Should all be fixed now.