search

poiuytrez / AndroidInAppBilling

Android App Billing plugin for Cordova
173 stars 144 forks source link

Plugin #103

Open maxs15 opened 8 years ago

maxs15 commented 8 years ago

hi @poiuytrez,

Could you please update the current version and create a tag (3.0.3 maybe?) I'm working on a new pull request that should fix the issues with the callbacks, I will increment the version as well in the PR.

Thanks :)

poiuytrez commented 8 years ago

Hi maxs15,

What do you mean by "update the current version"? Why do we need to have a tag to include the PR?

Thank you !

maxs15 commented 8 years ago

I mean tagging the commits with a version at least for the major modifications. People would be then able to download the version they need and we would be able to track bugs more easily. For example, when you merged this commit @84a421f8c7fa9 you introduced a breaking change because the billing key handling changed. With a new version release people can still target the version they need and at least be aware of change. So much easier to deal with versions instead of commits id :)