search

poiuytrez / AndroidInAppBilling

Android App Billing plugin for Cordova
173 stars 144 forks source link

Allow to specify license key via plugin parameter #78

Closed simoneb closed 9 years ago

simoneb commented 9 years ago

As requested in #31 PGB currently does not allow customizing any steps of the build process, thus preventing the use of this plugin because there would be no way to customize or provide the Android license key.

This pull request changes the installation procedure of the plugin requiring to provide the license key upon installation (when installing using the cordova cli) and upon configuration in the config.xml file (when configuring for PGB). The changes are minimal although they lead to a different installation procedure which is not compatible anymore with the previous one, based on copying the res xml file to the platforms folder (I tried to figure out whether it was possible to keep a backwards compatible way to install the plugin but that doesn't seem to be possible).

sebastianzillessen commented 9 years ago

:+1: awesome idea @simoneb !

poiuytrez commented 9 years ago

Thank you for the contribution. Could you update the documentation ? I will then merge the pull request.

simoneb commented 9 years ago

Check out the updated README, it carries all the documentation changes.

On Mon, Oct 20, 2014 at 9:54 AM, Guillaume Charhon <notifications@github.com

wrote:

Thank you for the contribution. Could you update the documentation ? I will then merge the pull request.

— Reply to this email directly or view it on GitHub https://github.com/poiuytrez/AndroidInAppBilling/pull/78#issuecomment-59698289 .