Open ninjaprawn opened 7 years ago
I've created this PR: https://github.com/ninjaprawn/electrino/pull/1/files
That adds better support. Nevertheless the whole thing should follow this documentation: https://nodejs.org/api/modules.html#modules_all_together
Some things that we will need to implement:
./
or ../
__dirname
and __filename
module
object has more things (such as the loaded
attribute), and I think this is the object that should be stored in the require cache (not the exports
one, although obviously module.exports
is the thing that needs to be returned when requiring the module).I think that once we've established where the project is heading, we will add those features in a reliable way.
Hi @ninjaprawn @gimenete @kittsuphatt !
Thanks very much for this. (I failed at Github and just didn't notice this pull request until now.)
I'll take a look and merge ASAP.
@ninjaprawn would be awesome if you can fix the merge conflicts. I can merge this after testing it out
Oh man -- when I wrote "ASAP", I didn't mean to imply "20 days later". Sorry for that. I've just been swamped.
I can check out and fix the merge conflicts on this one tomorrow, I think.
I won't be able to do much for the next couple of days (I'm flying back from WWDC to Australia, which is a long time). If nothing is done until then, I'll be more than happy to fix the conflicts
What ever happened to this project?
@ninjaprawn is this PR ready to review?
@ninjaprawn please help with the merge conflicts!
sorry this took so long! should be good to go now
@pojala let's move ahead with this PR! 😄
this proj is still active?
@gimenete Should this be closed since your PR was merged?
@amilajack my PR improved things, but was not implementing everything. I'm unsure about the state of the current implementation.
The implementation should follow this spec https://nodejs.org/api/modules.html#modules_all_together
@ninjaprawn Would love if you could the merge conflicts one last time. I'll definitely merge this right after you fix them.
@ninjaprawn could you help us out with the merge conflicts - we are looking to merge this in.
Modules are a key aspect in creating an application. In Node.js, modules can be installed and imported.
This PR adds support for importing js files, as well as modules that could come from Node packages.
What this PR does:
require
implementationJSContext
which is a duplicate of the default one-copyWithZone:
methodtest-app
folder toapp
app
group to a folder reference, so that files can be easily copied without having to manually add them to aCopy Files
phase.If you have any questions, feel free to ask :)