pojala / electrino

Desktop runtime for apps built on web technologies, using the system's own web browser engine
MIT License
4.37k stars 101 forks source link

Support for importing js files and modules via require #5

Open ninjaprawn opened 7 years ago

ninjaprawn commented 7 years ago

Modules are a key aspect in creating an application. In Node.js, modules can be installed and imported.

This PR adds support for importing js files, as well as modules that could come from Node packages.

What this PR does:

If you have any questions, feel free to ask :)

gimenete commented 7 years ago

I've created this PR: https://github.com/ninjaprawn/electrino/pull/1/files

That adds better support. Nevertheless the whole thing should follow this documentation: https://nodejs.org/api/modules.html#modules_all_together

Some things that we will need to implement:

ninjaprawn commented 7 years ago

I think that once we've established where the project is heading, we will add those features in a reliable way.

pojala commented 7 years ago

Hi @ninjaprawn @gimenete @kittsuphatt !

Thanks very much for this. (I failed at Github and just didn't notice this pull request until now.)

I'll take a look and merge ASAP.

amilajack commented 7 years ago

@ninjaprawn would be awesome if you can fix the merge conflicts. I can merge this after testing it out

pojala commented 7 years ago

Oh man -- when I wrote "ASAP", I didn't mean to imply "20 days later". Sorry for that. I've just been swamped.

I can check out and fix the merge conflicts on this one tomorrow, I think.

ninjaprawn commented 7 years ago

I won't be able to do much for the next couple of days (I'm flying back from WWDC to Australia, which is a long time). If nothing is done until then, I'll be more than happy to fix the conflicts

genesy commented 5 years ago

What ever happened to this project?

amilajack commented 5 years ago

@ninjaprawn is this PR ready to review?

paramaggarwal commented 5 years ago

@ninjaprawn please help with the merge conflicts!

ninjaprawn commented 5 years ago

sorry this took so long! should be good to go now

paramaggarwal commented 4 years ago

@pojala let's move ahead with this PR! 😄

genesy commented 4 years ago

this proj is still active?

amilajack commented 4 years ago

@gimenete Should this be closed since your PR was merged?

gimenete commented 4 years ago

@amilajack my PR improved things, but was not implementing everything. I'm unsure about the state of the current implementation.

The implementation should follow this spec https://nodejs.org/api/modules.html#modules_all_together

amilajack commented 4 years ago

@ninjaprawn Would love if you could the merge conflicts one last time. I'll definitely merge this right after you fix them.

paramaggarwal commented 4 years ago

@ninjaprawn could you help us out with the merge conflicts - we are looking to merge this in.