search

pojntfx / adwaita-gtk-ubuntu-legacy

To test out whether it may be a better idea to use Adwaita instead of Ambiance in LTS if Communitheme won't be done in time.
GNU General Public License v3.0
2 stars 0 forks source link

no green or red buttons #2

Open ghost opened 6 years ago

ghost commented 6 years ago

the green or red buttons are unity8-blue too. They should stay green or red because of their meaning. bildschirmfoto von 2018-02-14 18-45-27 More precisly this red and green: https://docs.google.com/presentation/d/1FtHFW67ycl6uvxZqKIZwyinVyOuV9NxXDuJv1SwQ70k/edit#slide=id.g13b3c671fc_1_0

pojntfx commented 6 years ago

Sure, I was just using Adwaita defaults, and it does not seem to follow the "traffic light principle". This would require changing Adwaita source - I've already applied the $success-color etc. scss variables but they do not get applied to the buttons by design. I could also just make overrides based on css classes (i.e. .button-proceed {background: $success-color;}, but that would be a sort of ugly hack ... What do you think? Should I do it? Or stay close to stock Adwaita?

ghost commented 6 years ago

Stock Adwaita would mean that the green/red-buttons are included, right? Than we should go stock. I would recommend to avoid hacks to stay as close as possible to the original Adwaita-code. Could the reason the "traffic light principle" is not followed that you used communitheme as base?

pojntfx commented 6 years ago

As far is i know, no. Also, Adwaita is the base - just the build system is from Communitheme. Changing this would mean either forking it or overriding. Source: https://blogs.gnome.org/aday/2017/05/16/new-simple-scan-designs/

ghost commented 6 years ago

oh... i am confused now. I tested stock-adwaita once again and... no green buttons. I really thought the "traffic light principle" would be part of adwaita. Or did they change it since gnome 3.26?