pojome / one-click-accessibility

The One Click Accessibility plugin is the fastest plugin to help you make your WordPress website more accessible.
https://wpaccessibility.io/
77 stars 32 forks source link

Widget markup does not use semantic HTML #68

Open mikemai2awesome opened 3 years ago

mikemai2awesome commented 3 years ago

The widget should use semantic markup and be accessible itself. This is a tool and it has functionalities. It should not be built with <nav> and <a> elements. Instead, it should be built as a menu with semantic <button> for each menuitem.

  1. Incorrect usage of <nav>: https://github.com/pojome/one-click-accessibility/blob/52ef94b53997670697e5c492cad2e45eda39aff2/includes/pojo-a11y-frontend.php#L102
  2. Incorrect usage of <a>: https://github.com/pojome/one-click-accessibility/blob/52ef94b53997670697e5c492cad2e45eda39aff2/includes/pojo-a11y-frontend.php#L119