search

pok3r-custom / pok3r_re_firmware

Reverse engineering project for the POK3R and related keyboards.
219 stars 17 forks source link

Problem: I was missing usb.h, and lazy submodules #9

Closed karlhungus closed 6 years ago

karlhungus commented 6 years ago

Solution: provide instructions for getting submodules and usb.h

@ChaoticConundrum not sure how you feel about this.

theyy29 commented 6 years ago

Not everyone runs ubuntu. I do not have a libusb-dev package on my system; not even an equivalent package. If I tried to find one, I would get nothing but confusion (and it would work if I did nothing).

Also, the readme already says that the submodule needs to be cloned, the specific command to do so is a google search away (if you don't remember it).

karlhungus commented 6 years ago

:cool:

ChaoticEnigma commented 6 years ago

This raises a fair point. My system ships with a libusb-0.1 usb.h, but not all systems do. I currently don't note that libusb-0.1 is a dependency on the assumption it would be obvious to anyone building this at this stage. When I expect this to be more user-friendly, I will have pre-built binaries.

The issue in my eyes, is that if I want to provide build support for one platform, I should have it for each platform, and setting up the build environment for this on Windows is a huge pain. The easiest solution that covers each platform is to build binaries for each platform, when I expect this to have some end-user use.