search

pokealarm / pokealarm

PokeAlarm is a highly configurable application designed to give you complete control over your PokémonGO notifications.
GNU Affero General Public License v3.0
310 stars 323 forks source link

Add "geofence_excludes" restriction #652

Closed FakeKitten closed 2 years ago

FakeKitten commented 6 years ago

Description

An exclusion geofence.

Why is this enhancement necessary or useful?

Currently for something like ex gyms the easiest way to filter them is by name but this can cause issues where two gyms have the same name. A small exclusionary geofence around the offending gyms would be far easier than trying to geofence all acceptable gyms.

How can this enhancement be accomplished?

Taking the code for geofences and turning it upside down.

billyjbryant commented 6 years ago

Why not exclude these @ the scanner so that PA just doesn't get alerted for them?

FakeKitten commented 6 years ago

I'd still like to know about raids at those gyms, I just have a specific filter for a ex gym channel

billyjbryant commented 2 years ago

This requires a major overhaul of how filters work. Right now filters are additive only not subtractive. This requires a subtractive geofences filter that would need to know a list of valid Geofences to remove the appropriate geofence. It would be much easier to create a new alert that uses the existing geofences filter and just excludes that geofence.