search

pokeb / asi-http-request

Easy to use CFNetwork wrapper for HTTP requests, Objective-C, Mac OS X and iPhone
http://allseeing-i.com/ASIHTTPRequest
Other
5.78k stars 1.41k forks source link

fix cancel crash in latest version of asi #405

Open grittymindy opened 8 years ago

grittymindy commented 8 years ago

The crash happens if you cancel a request that satisfies:

  1. currently waiting in queue, not been started yet
  2. there is valid cached data for this request in downloadCache

The fix is similar to https://github.com/jogu/asi-http-request/commit/887fcad0f77e9717f003273612804a9b9012a140. That's, avoid calling markAsFinished unless we're in progress.