ARC support and fix all warnings and errors for Xcode 9.1 and iOS 11.1

pokeb / asi-http-request

Easy to use CFNetwork wrapper for HTTP requests, Objective-C, Mac OS X and iPhone

http://allseeing-i.com/ASIHTTPRequest

Other

5.78k stars 1.41k forks source link

ARC support and fix all warnings and errors for Xcode 9.1 and iOS 11.1 #412

Open rivera-ernesto opened 6 years ago

rivera-ernesto commented 6 years ago

PR includes:

• Fixes from forks by @OpenFibers (#356), @John1261, @gbanfalvikl and @whlsxl (#377). • Fixes for all build warnings in Xcode 9.2. • Fixes for all Analyzer warnings in Xcode 9.2. • Tested to be working on iOS 9.0~11.1. • Not yet working on macOS.

While this PR will more likely never be merged, anyone can use it by adding pod 'ASIHTTPRequest', :git => 'https://github.com/codelathe/asi-http-request.git' to their Podfile.

jogu commented 6 years ago

There’s a definite chance of this getting merged if several people comment to say that it works for them in their project & that they have also reviewed the code and found no issues.

We’ll definitely not merge a pod spec unless it is very clearly marked as saying the asihttprequest is obsolete and should almost never be used. We don’t want anyone to accidentally incorporate asi into their projects.

(I’d be interested to know why people are still using ASI too...!)

rivera-ernesto commented 6 years ago

In my case I am just maintaining an old project that uses the library. If it ain't broken...

And you're right. I'll add the discontinued disclaimer.

venjye commented 6 years ago

Nice work . man!