search

pokeclicker / pokeclicker

The new and improved version of the popular idle/incremental PokéClicker
https://www.pokeclicker.com
560 stars 324 forks source link

[SUGGESTION] Allow eggs and fossils to be placed in the hatchery queue #1362

Open DeniZgamR opened 3 years ago

DeniZgamR commented 3 years ago

Current Behavior The hatchery queue doesn't allow for eggs and fossils to be placed inside

Improved Behavior I would like to see the hatchery queue being able to take eggs and fossils

Reason for change We have to clear out the queue if we want to add an egg or a fossil

Detailed Description instead of placing the eggs/fossils directly into the hatchery I would like to see it being able to put into the queue aswell

Screenshots:

image

Qwertypop4 commented 3 years ago

Eggs and fossils can't wait in a queue, as they cannot move

Latecomerr commented 2 years ago

Bumping for interest...

CorgiOnNeptune commented 2 years ago

I could see if I could get this working.

Tricky part would probably be putting typed/mystery eggs in queue without revealing what they are until they are in the hatchery (Use the default inventory image for type/mystery in queue). Either that or make it so you can’t remove the type/mystery eggs from queue if they’re revealed. But I think first way would be cleaner.

Ultima1990 commented 2 years ago

Bumping for interest...

If you don't have anything to say, better to not say anything.

IdlerDude commented 1 year ago

The following is a comment I made in chat. I had no idea this issue existed. BUT, this is the "story" I would use to explain the way it works if no one ever submits a fix. :)

My guess is that the queue is separate from the nursery. Hatchery queue is like a pen for live animals and the incubator is only for eggs/fossils.

onthefritz commented 3 weeks ago

Apologies for bringing this back again and apologies if I'm over stepping at all. I have an interest in this as well and have a suggestion for how this could work. I've seen in the other suggestions that there is/was a PR for this but I couldn't find that (it was stated back in 2022).

The idea though is that it would effectively be an Incubator queue. Story wise, a Hatchery Helper pulls Eggs and Fossils from the Incubator queue.

How the queue works: It can hold a number of Eggs or Fossils equal to half the total of the Breeding queue. The picture would just be of the type of Egg or Fossil while in this queue so as to not give away what it is. A Hatchery Helper is required to pull from that queue. Any Hatchery Helper is fine. I would guess a new flag would need to be added to the Helpers to account for watching that queue and some changes around the Helpers since they can't hold Eggs or Fossils today. If they watch the Incubator queue then they can't pull from the Pokemon though. Cost and everything else would stay the same. I would also say you still can't give a Helper an Egg or Fossil. They would only be able to pull from this new queue. As for location, it would exist just underneath the Breeding queue when there are Eggs or Fossils in it.

I looked around the code a few times. Months to years ago at this point but wouldn't mind trying to look into implementing something like this if you all would be alright with this idea.

EDIT: I found the PR. It seems it went stale. If that is the preferred approach I can look into getting that updated and ready for PR again.