robinjoseph08
commented
12 months ago Hey @Fleker, apologies for not getting to this sooner. I really appreciate you taking the time to work on this.
Recently, I did a major overhaul of this repo to upgrade all the packages, switch to TypeScript, organize the files better, etc., so it would've been rough to rebase it, so I carried your changes over to a separate PR, and I merged and deployed that, so Pokedex Tracker should now be installable as a PWA. I'm not well-versed in PWAs, but it was a lot easier to understand with your PR as a base, so once again, I appreciate the work that you did.
One change I wanted to note was that instead of adding a /u/me that rendered your profile, I ended up adding a /profile route that just redirected to the correct location. I chose /profile over /u/me because that route would prevent anyone from viewing the user me's profile which is unfortunate. And the redirect seemed like a cleaner approach so that we could send the user to the login page if they weren't logged in.
The 2 things that I didn't copy over were:
- I left off the
screenshotsproperty of the manifest. It seems likes just for promotional purposes, not functionality purposes, so I opted to leave it off for now. - I omitted the service worker changes. It seemed like just having an empty service worker doesn't provide any added functionality by itself, and since adding in additional functionality in the service worker seemed like a larger lift, I opted to not do it for now to at least get this shipped faster. If we find that there's additional functionality that would be worthwhile for us to add (e.g. offline capabilities), we'll have separate issues to keep track of those.
Thanks again for putting up this PR, and sorry I didn't get to it sooner!
Addresses #456 by adding a
manifest.jsonand a barebonessw.jsservice workerThe PWA jumps by default to your profile page using
/u/meas a new route that uses the session user details.Include additional PWA polish such as screenshots and shortcuts.