Submitting the "Mickey fix" on gifvex's behalf. This fixes two issues (1 major, 1 minor) seen in Mickey's Dangerous Chase testing, while attempting to console-verify a resynced TAS:
Major fix: Use CGB LCD timings for DMG-only games being played on CGB. (Previous GSR behavior switched the whole LCD to DMG for these games; this didn't matter for Pokémon Red/Blue, but it does matter for DMG-only games like Mickey that use more LCD functionality.)
Minor fix: Fix writes to $FF22 (NR43) to reset counter_. This was uncovered since the sound effect for taking damage in Mickey appeared to be skipped in all versions of Gambatte. Debugging showed the noise channel playing a single sample of the effect, then not producing sound until reaching counter_ ~0.5 seconds later (after an $E7 write, implying ~2 Hz sound). Resetting counter_ on $FF22 writes resulted in the proper behavior of playing the full sound effect.
All hwtests still pass after these changes, and no other regressions in behavior have been observed in testing (or in re-encodes of previous movies).
Submitting the "Mickey fix" on gifvex's behalf. This fixes two issues (1 major, 1 minor) seen in Mickey's Dangerous Chase testing, while attempting to console-verify a resynced TAS:
Major fix: Use CGB LCD timings for DMG-only games being played on CGB. (Previous GSR behavior switched the whole LCD to DMG for these games; this didn't matter for Pokémon Red/Blue, but it does matter for DMG-only games like Mickey that use more LCD functionality.)
Minor fix: Fix writes to $FF22 (NR43) to reset
counter_. This was uncovered since the sound effect for taking damage in Mickey appeared to be skipped in all versions of Gambatte. Debugging showed the noise channel playing a single sample of the effect, then not producing sound until reachingcounter_~0.5 seconds later (after an $E7 write, implying ~2 Hz sound). Resettingcounter_on $FF22 writes resulted in the proper behavior of playing the full sound effect.All hwtests still pass after these changes, and no other regressions in behavior have been observed in testing (or in re-encodes of previous movies).