pokemon-speedrunning / gambatte-speedrun

Fork of https://github.com/sinamas/gambatte with Pokemon speedrunning-related changes.
GNU General Public License v2.0
94 stars 27 forks source link

HuC3 implementation incomplete/possibly broken on edge cases #45

Open Dabomstew opened 4 years ago

Dabomstew commented 4 years ago

From https://twitter.com/liji32/status/1262661004678311937 :

"I had a look and it seems very hardcoded for Robopon, and also misses a command used by Pocket Family, so it won’t work for that game. (Also timing is wrong in both it and SameBoy so it invalidates TASes)"

"I’m not even sure how accurate it is for Robopon right now, I think there might be some edge case where it breaks."

See about cross-referencing SameBoy's implementation to patch these issues up. Probably not worth bothering with the alarm clocks though.