pokemon-speedrunning / gambatte-speedrun

Fork of https://github.com/sinamas/gambatte with Pokemon speedrunning-related changes.
GNU General Public License v2.0
94 stars 27 forks source link

Star Trek 25th Anniversary: Misaligned Border #58

Open alyosha-tas opened 4 years ago

alyosha-tas commented 4 years ago

The border in the intro text screen is misaligned. You can see it in this video for example, where it's zoomed in and really obvious:

https://www.youtube.com/watch?v=KsthKsr_2Sw&t=32s

You can also see it in this video, where it appears to be played on a gameboy player:

https://www.youtube.com/watch?v=HCmIQ24AMgo&t=62s

However, there are 2 videos where the border is properly aligned, one is played on SGB:

https://www.youtube.com/watch?v=bEArrvHV6wQ&t=181s

The other I'm not sure about:

https://www.youtube.com/watch?v=K-4r30hHwsA

The game uses the Window in a non-standard way. The top few scanlines are part of the window, then it turns off the window and the normal background is used for the text part, then turns the window back on for the bottom of the screen.

If the background is emulated normally, then it is in fact misaligned. If you look at the 2 videos with proper alignment, there is a clear blank vertical line on the left side of the screen. So, for some reason the background is being shifted to the right one pixel for the alignment to work out.

I have confirmed on my own Gameboy Player that the border is mis-aligned. I don't have a SGB or original GB personally to test on.