pokemon-speedrunning / gambatte-speedrun

Fork of https://github.com/sinamas/gambatte with Pokemon speedrunning-related changes.
GNU General Public License v2.0
94 stars 27 forks source link

fix FEA0-FEFF memory range for CGB/AGB #70

Closed CasualPokePlayer closed 3 years ago

CasualPokePlayer commented 3 years ago

AGB (and CGB-E) handles this memory range differently than the CGB-D (which is what Gambatte seems to be emulating for some reason). Simply, the byte read will have both nibbles equal the third nibble of the address (e.g. a read in FEA0 will return AA), and writes will have no effect. Unsure if keeping around the old cgb code is the best idea, but it can be changed if needed. EDIT: After some talk with entr, getting rid of old revision code seems to be the best option forward.

Also, porting this code over to Bizhawk should resolve this: https://github.com/TASVideos/BizHawk/issues/1987